-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix color detection #1265
Fix color detection #1265
Conversation
bin/lint-staged.js
Outdated
if (supportsColor.stdout) { | ||
process.env.FORCE_COLOR = supportsColor.stdout.level.toString() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the original detection logic from before version 13.0.0.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 735 735
Branches 198 198
=========================================
Hits 735 735
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks like |
7d00055
to
519bbfb
Compare
Ping @okonet should we merge this? |
Lgtm! |
Looks like |
Should we switch to changesets? I feel it is much more reliable and controllable. |
It might be good, yes... I'm up for it but would need to spend some on it, unless you want to implement. For now maybe I just create two empty |
Actually, a single |
I can implement when I find some time. No pressure ;) |
Changes in `semantic-release` seem to make it difficult to publish pre-releases into `lint-staged@next`, so disable it for now. For more info, see the following PR: #1265
Changes in `semantic-release` seem to make it difficult to publish pre-releases into `lint-staged@next`, so disable it for now. For more info, see the following PR: #1265
Changes in `semantic-release` seem to make it difficult to publish pre-releases into `lint-staged@next`, so disable it for now. For more info, see the following PR: #1265
Update dependencies and restore and
chalk
for improved color support detection. This should fix issues with Windows terminals multiplying or otherwise messing up the output.