Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): set environment to reflect #9e79050 #190

Merged
merged 1 commit into from
Jun 12, 2017
Merged

chore(eslint): set environment to reflect #9e79050 #190

merged 1 commit into from
Jun 12, 2017

Conversation

luftywiranda13
Copy link
Collaborator

due to test framework migration from mocha to jest,
eslint env should also be set to jest

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          67     67           
  Branches        8      8           
=====================================
  Hits           67     67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfe017...9fdfdb5. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented Jun 12, 2017

Thanks! This slipped down during the migration.

@luftywiranda13
Copy link
Collaborator Author

@okonet oopsss, I'm sorry 😔
I think I accidentally included package-lock.json in this PR.

want to remove it?
or how about if I submit a PR doing the same thing like https://github.com/luftywiranda13/eslint-config-bunny/pull/98?
so it'll never happen again in the future

@okonet
Copy link
Collaborator

okonet commented Aug 6, 2017

Good idea. Please create a new PR for that.

@luftywiranda13
Copy link
Collaborator Author

sure, i'm working on it

This was referenced Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants