Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force patch release 'Return from function on reject' (#255) #266

Closed

Conversation

sudo-suhas
Copy link
Collaborator

This PR adds an empty commit to force a patch release with changes in #255. Related issue - #264.

@okonet
Copy link
Collaborator

okonet commented Sep 6, 2017

That didn't work or why did you close it?

@sudo-suhas
Copy link
Collaborator Author

I have no idea why this got closed. Must have pressed the close by mistake.

@okonet
Copy link
Collaborator

okonet commented Sep 6, 2017

Probably because of no changes... GitHub trying to be smart ¯_(ツ)_/¯

@okonet
Copy link
Collaborator

okonet commented Sep 6, 2017

I'll commit directly to master. That won't work either 🤦‍♂️

@sudo-suhas sudo-suhas reopened this Sep 6, 2017
@codecov
Copy link

codecov bot commented Sep 6, 2017

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #266   +/-   ##
======================================
  Coverage    89.5%   89.5%           
======================================
  Files          10      10           
  Lines         162     162           
  Branches       23      23           
======================================
  Hits          145     145           
  Misses         16      16           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c3d26...004cea2. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented Sep 6, 2017

See #267

@okonet okonet closed this Sep 6, 2017
@sudo-suhas sudo-suhas deleted the fix/force-patch-release branch September 9, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants