-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update husky post-commit configuration #566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
- Coverage 98.13% 98.02% -0.12%
==========================================
Files 13 13
Lines 376 354 -22
Branches 52 45 -7
==========================================
- Hits 369 347 -22
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update husky to 1.x in this package?
I don't know if it is what you mean |
No I meant that it would be great if you could upgrade this repo to husky 1.x. Also I’m wondering if we still need this examples with git. |
Since the issue with IntelliJ was resolved we can delete these sections from the documentation. |
Any update on this PR? My team is still on an earlier version of Webstorm so this section was helpful when setting up lint-staged on our repo. However I was confused because of the husky v0.x config for the Webstorm workaround when the rest of the examples in the docs use the husky v1.x config. |
@jacobworrel Althougth I don't know why this PR not merged, you still can use its code example. It works for me. |
This PR isn’t merged since the feedback I gave wasn’t addressed. |
@okonet
I guess you mean package.json should update, but I looked at it, I found it was already husky 1.x. |
Ah good then. Another part was about the IntelliJ section in the docs since it was resolved in the meantime. |
I actually think we should just drop or hide the whole part with both 1.x and 0.x instructions. Thoughts? |
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
use v1.x husky configuration