Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update husky post-commit configuration #566

Merged
merged 3 commits into from
Jun 5, 2019
Merged

docs: update husky post-commit configuration #566

merged 3 commits into from
Jun 5, 2019

Conversation

levy9527
Copy link
Contributor

use v1.x husky configuration

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #566 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   98.13%   98.02%   -0.12%     
==========================================
  Files          13       13              
  Lines         376      354      -22     
  Branches       52       45       -7     
==========================================
- Hits          369      347      -22     
  Misses          7        7
Impacted Files Coverage Δ
src/getConfig.js 100% <0%> (ø) ⬆️
src/generateTasks.js 100% <0%> (ø) ⬆️
src/runAll.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315890a...5c84007. Read the comment docs.

okonet
okonet previously approved these changes Jan 17, 2019
Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update husky to 1.x in this package?

@levy9527
Copy link
Contributor Author

I don't know if it is what you mean

@okonet
Copy link
Collaborator

okonet commented Jan 23, 2019

No I meant that it would be great if you could upgrade this repo to husky 1.x. Also I’m wondering if we still need this examples with git.

@okonet
Copy link
Collaborator

okonet commented Jan 23, 2019

Since the issue with IntelliJ was resolved we can delete these sections from the documentation.

@jacobworrel
Copy link

Any update on this PR? My team is still on an earlier version of Webstorm so this section was helpful when setting up lint-staged on our repo. However I was confused because of the husky v0.x config for the Webstorm workaround when the rest of the examples in the docs use the husky v1.x config.

@levy9527 levy9527 changed the title update husky post-commit configuration docs: update husky post-commit configuration Apr 22, 2019
@levy9527
Copy link
Contributor Author

@jacobworrel Althougth I don't know why this PR not merged, you still can use its code example. It works for me.

@okonet
Copy link
Collaborator

okonet commented Apr 22, 2019

This PR isn’t merged since the feedback I gave wasn’t addressed.

@levy9527
Copy link
Contributor Author

@okonet
Your feedback is:

No I meant that it would be great if you could upgrade this repo to husky 1.x

I guess you mean package.json should update, but I looked at it, I found it was already husky 1.x.
So, actually I don't know what's wrong...

@okonet
Copy link
Collaborator

okonet commented Apr 22, 2019

Ah good then. Another part was about the IntelliJ section in the docs since it was resolved in the meantime.

@okonet
Copy link
Collaborator

okonet commented Apr 22, 2019

I actually think we should just drop or hide the whole part with both 1.x and 0.x instructions. Thoughts?

@okonet okonet merged commit 738af13 into lint-staged:master Jun 5, 2019
@okonet
Copy link
Collaborator

okonet commented Jun 6, 2019

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@okonet okonet added the released label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants