Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use internal execGit to list staged files #624

Merged
merged 1 commit into from Jun 23, 2019
Merged

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Jun 7, 2019

This pull request removes the staged-git-files and pify dependencies and uses the internal execGit to list staged files. This is done via

git diff --staged --diff-filter=ACM --name-only

This should be the same behaviour as `staged-git-files, since only the filenames were used.

@iiroj iiroj force-pushed the get-staged-files branch 2 times, most recently from fada7ab to 3d958fc Compare June 7, 2019 05:51
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #624 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.02%     
==========================================
  Files          14       15       +1     
  Lines         378      383       +5     
  Branches       51       53       +2     
==========================================
+ Hits          371      376       +5     
  Misses          7        7
Impacted Files Coverage Δ
src/getStagedFiles.js 100% <100%> (ø)
src/runAll.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e332c80...39746e7. Read the comment docs.

Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the proposal but let’s clean up a bit?

src/getStagedFiles.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/runAll.js Show resolved Hide resolved
src/runAll.js Outdated Show resolved Hide resolved
src/runAll.js Show resolved Hide resolved
@iiroj iiroj force-pushed the get-staged-files branch 2 times, most recently from 9cc7ac2 to 5f5913a Compare June 18, 2019 05:15
@okonet okonet merged commit 279863d into master Jun 23, 2019
@okonet okonet deleted the get-staged-files branch June 23, 2019 17:56
@okonet
Copy link
Collaborator

okonet commented Jul 1, 2019

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@okonet okonet added the released label Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants