Add more tests

[iiroj]

This PR adds two tests.

1: Should clear unstaged changes when linter applies same changes

1. There is a staged file that does not pass prettier’s formatting
2. There are unstaged modifications that properly prettify the file
3. lint-staged runs prettier --fix and git add to essentially do the same thing as the unstaged modifications

The result:

1. lint-staged succesfully fixed and committed the file
2. The unstaged modifications are gone, since they’re already in place

2: should fail when linter creates a .git/index.lock

1. There is a staged file that does not pass prettier’s formatting
2. There are further unstaged changes in the same file
3. lint-staged runs prettier --fix and git add, but also create a .git/index.lock file, failing git operations (like the git add)

The result:

1. lint-staged fails to create a new commit
2. git status matches the status before committing, but prettier's changes have been staged
3. The unstaged modifications are gone, replaced by previously staged modifications, and staged modifications contain linter changes.

[codecov]

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          11       11           
  Lines         305      305           
  Branches       57       57           
=======================================
  Hits          304      304           
  Misses          1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e879b6a...8f5b5b5. Read the comment docs.

[okonet]

Is this mergeable? Shouldn’t the second test fail until we fixed the root cause?

[iiroj]

@okonet I made the test to expect the failure result, so it succeeds. When the issue gets fixed, the test will start failing.

Given how the linter task creates a git lock, all git operations from there onwards will fail, so I doubt we can ever cleanly recover from it.

[okonet]

Great! Let’s merge then. Can you rebase it please?

[iiroj]

Alright, rebased.

[iiroj]

I've rebased against latest master, but sadly have no permissions to merge myself.

[okonet]

I think to solve that I’d need to create a separate organization. Thoughts?

[okonet]

🎉 This PR is included in version 9.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀