-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating TODO's deletes ember-template-lint TODOs #80
Comments
I got around this by passing in
|
Thanks for reporting @achambers! |
Ya, they absolutely are being developed to work well together (and "feel" the same in both worlds). This is a bug for sure. |
Oh wow this was a massive oversight on my part! Sorry for that, @achambers! I'll work on fixing this tomorrow. Thanks for reporting. |
Thanks folks. Very much appreciated. Love your work :) |
I’m happy to submit a PR myself, if that helps, if you can give me a steer on where to look. |
It's all good. I should have this fixed by end of day. Was just testing an api to support this in the underlying todo-utils lib that both linting libraries use. |
What I expected to happen
Run
UPDATE_TODO=1 eslint --format @scalvert/eslint-formatter-todo
and see a list of new eslint TODOsWhat actually happened
I ran
UPDATE_TODO=1 eslint --format @scalvert/eslint-formatter-todo
and saw a list of new eslint TODOs but also all existing ember-template-lint TODOs were deleted.It looks like running eslint with this formatter deletes any TODOs that were created by https://github.com/ember-template-lint/ember-template-lint which I was not expecting to happen.
I see that you're involved with ember-template-lint so I imagine your intention would be to have them co-exist.
I see in the todo json file that an
engine
property is present which suggests that tools like this should be able to target only TODOs generated for this tool.Am I doing something wrong or is this a legit bug?
The text was updated successfully, but these errors were encountered: