Ensure correct stylelint versions are being used #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyLei94
changed the title
scalvert
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel PR to: lint-todo/eslint-formatter-todo#397
This brings in validate-peer-dependencies and runs it when the formatter is required/loaded. This will emit a helpful error if stylelint version isn't compliant with our peer dependency requirements.
Eslint and stylelint were listed as an explicit dependency (which is generally an error condition, when you use peerDependencies), so both are moved to dev dependencies.
This PR also removes yarn.lock as well as we don't use yarn installation.