Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One very small code contribution: Click to Tray Menu Title "Lintalist - x.y.z" opens the Script Dir #102

Open
schittli opened this issue Jun 8, 2018 · 3 comments

Comments

@schittli
Copy link

schittli commented Jun 8, 2018

Good Afternoon

This was the last feedback:

  1. It looks like the Bundle TitleMatch does not work
    For example, the MarkDown bundle was always active, so they added some random characters like ZuOhTcVP to the TitleMatch, but it was still active in all Windows.
  2. Therefore, they asked if a Bundle could be disabled until it will manually be re-enabled.
    I think this idea is not supported, and because I don't know Autohotkey very well, I've added a small workaround so that they can quickly open the Bundles Directory :-):

If the Tray Menu Title Lintalist - 1.9.6 is clicked, then Windows Explorer opens the Script Dir:

Lintalist\lintalist.ahk

GlobalMenuHandler:
ControlGetFocus, Control, Lintalist snippet editor

; tray menu
If (A_ThisMenuItem = AppWindow)
	run % a_scriptdir
Else If (A_ThisMenuItem = "&Help")
	Run, docs\index.html
…

Maybe you find it useful.
Kind regards,
Thomas

@lintalist
Copy link
Owner

lintalist commented Jun 8, 2018

Bundle TitleMatch does not work

For me the markdown bundle is only active when I have a markdown file open otherwise it is not.
So either they have selected 'load all bundles' which means all bundles are loaded of course - this should be visible in the GUI, Bundle menu option - all items in the menu will have a checkmark ✔ - or something is wrong with the Window title in the editor and/or in the file name.

Could you tell / show me:

  • in the settings there is an option AlwaysLoadBundle - do you have the markdown bundle there? If so it will always be loaded. Remove it.
  • what (markdown) editor are you're using - perhaps it doesn't show the MD in Window title - if it is a free editor I can perhaps try it myself
  • what is an example of a markdown filename you are editing (readme.md or readme.markdown) or a variation.

If a Bundle could be disabled until it will manually be re-enabled.

You can actually select a bundle manually. Open the GUI, select the Bundle from the menu. Now that bundle (say Markdown) is "locked" and always active this should also be visible by the "locked" icon in the toolbar.

If the Tray Menu Title is clicked

What would be the advantage of opening the script folder via the Tray menu? I don't mind adding it but not sure why it would be useful.
Edit: why not have it open the Search GUI instead for example.

@schittli
Copy link
Author

Thank you very much for your support!,
you're right, they activated all bundles because they thought that "Load All Bundles" must be active so that all bundles are used by Lintalist. :-)

Therefore I have a small suggestion:

Maybe the user interface would be easier to understand if the menu item is renamed:

  • Original:
    Bundle
    ☑️ Load All Bundles
  • Suggestion 1:
    Bundle
    ☑️ Activate All Bundles

    (This would suggest, that the Bundles must not be loaded (because they already are), but that the usage can be enforced. Unfortunately, it does not say that they are dyanmically used by Lintalist by default)
  • Therefore: Suggestion 2: two menu points, if one is activated, then the other gets deacitvated (I don't use radio buttons because I don't know if it can easily handled in Autohotkey):
    Bundle
    ☑️ Dynamically use all Bundles
    🔲 Enforce using all Bundles

Re: What would be the advantage of opening the script folder via the Tray menu?

Because my users are not software developers, it was a bit difficult to find the path to the bundles for them. Therefore I added this code to quickly find the installation directory :-)

After clarifying the misunderstanding of the "Load all Bundles" menu item, I cannot assess whether it would still be useful for the users, to quickly find the installation directory.

@lintalist
Copy link
Owner

lintalist commented Jun 10, 2018

Maybe the user interface would be easier to understand if the menu item is renamed:

Suggestion 2 makes sense, I'll look into adding it.

What would be the advantage of opening the script folder via the Tray menu?

So I could add an additional tray menu item: "Open Lintalist folder..." and have "Lintalist vx.y.z" open the Gui. Edit: I've done so already for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants