Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add config tests #52

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Conversation

ifedchankau
Copy link
Collaborator

Add 11 config tests:

  • without delimiter (valid)
  • empty config (valid)
  • without examples section (valid)
  • with full data (valid)
  • without name in section (invalid)
  • without options section (valid)
  • with other data in config (invalid)
  • with other data in section (invalid)
  • with other section (invalid)
  • without section (valid)
  • without usage section (valid)

Closes #51

Add 11 config tests:
- without delimiter (valid)
- empty config (valid)
- without examples section (valid)
- with full data (valid)
- without name in section (invalid)
- without options section (valid)
- with other data in config (invalid)
- with other data in section (invalid)
- with other section (invalid)
- without section (valid)
- without usage section (valid)

Closes linterhub#51
Copy link
Contributor

@itekaf itekaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some files need to refactoring. Create a separate issue for that

@itekaf itekaf merged commit 938d85c into linterhub:develop Jul 25, 2018
@ifedchankau ifedchankau mentioned this pull request Jul 25, 2018
@itekaf
Copy link
Contributor

itekaf commented Aug 20, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants