Bluetooth: host: handle error case on sync cmd #18
+64
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthitce
reviewed
Dec 28, 2023
drivers/bluetooth/hci/h4.c
Outdated
| @@ -529,6 +529,15 @@ static int h4_open(void) | |||
| return 0; | |||
| } | |||
|
|
|||
| static int h4_close(void) | |||
| { | |||
| LOG_DBG(""); | |||
drivers/bluetooth/hci/h5.c
Outdated
| @@ -750,6 +750,19 @@ static void h5_init(void) | |||
| k_work_init_delayable(&retx_work, retx_timeout); | |||
| } | |||
|
|
|||
| static void h5_deinit(void) | |||
| { | |||
| LOG_DBG(""); | |||
drivers/bluetooth/hci/h5.c
Outdated
| @@ -768,10 +781,20 @@ static int h5_open(void) | |||
| return 0; | |||
| } | |||
|
|
|||
| static int h5_close(void) | |||
| { | |||
| LOG_DBG(""); | |||
| @@ -768,10 +781,20 @@ static int h5_open(void) | |||
| return 0; | |||
| } | |||
|
|
|||
| static int h5_close(void) | |||
subsys/bluetooth/host/hci_core.c
Outdated
| @@ -4065,17 +4078,31 @@ int bt_enable(bt_ready_cb_t cb) | |||
| err = bt_dev.drv->open(); | |||
| if (err) { | |||
| LOG_ERR("HCI driver open failed (%d)", err); | |||
| return err; | |||
| goto error; | |||
| } | |||
|
|
|||
| bt_monitor_send(BT_MONITOR_OPEN_INDEX, NULL, 0); | |||
|
|
|||
| if (!cb) { | |||
parthitce
reviewed
Dec 29, 2023
| { | ||
| h5_deinit(); | ||
|
|
||
| uart_irq_rx_disable(h5_dev); |
There was a problem hiding this comment.
disable the interrupt first to be sure that we can cancel the works and kill the rx thread.
ssekar15
reviewed
Dec 29, 2023
subsys/bluetooth/host/hci_core.c
Outdated
| } else { | ||
| err = bt_init(); | ||
| if (err) { | ||
| bt_dev.drv->close(); |
added hci driver close support for h4 and h5 Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
bt_hci_cmd_send_sync will return 0 on error if CONFIG_BT_ASSERT is disabled, which make bt_enable success even if there is no response from controller Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return error when no response is received from
controller when CONFIG_BT_ASSERT is disabled.