New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement automatic board detection #32
Conversation
Looks like the build is failing with
Perhaps the error checker does not have this file. I've reimplemented the try:except so the build works. |
According to https://gitlab.freedesktop.org/Miouyouyou/RockMyy/-/issues/11#note_135858 The Tinkerboard shows "Rockchip RK3288 Tinker Board" when you `cat /proc/device-tree/model` So I improved the logic.
I put the try/except back in to see if the build passes now.
Catch invalid board types with try:except so build passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice start, thank you! Some feedback below.
Co-authored-by: Linus Groh <mail@linusgroh.de>
I am ready for a re-review |
Seems to be failing with
Without
According to https://stackoverflow.com/questions/46641078/how-to-avoid-circular-dependency-caused-by-type-hinting-of-pointer-attributes-in this import is required to allow for names to not be evaluated at compilation Looks like it may be Python 3.7+ only |
oh, hmm. Let's remove the annotations import then and make the return type |
Thanks Linus for your guidance |
Hi, |
|
Fixed the version parser argument formatting, thanks! |
🚀 |
Hi Linus,
I have taken a stab at implementation.
It works!
A few points for you to review
-I am not sure if I did the enumeration to your liking.
-I removed the part in the readme, now that it works out of the box.
-After I blacked the files, it rearranged the whitespace on your argument parser
-I didnt know if I should put the _get_board in the Backlight class. I'm not very good with OOP, so I was not able to access it with self._get_board(). My guess is because it hasn't been init'd yet.
Thanks,
Fixes #30