Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build #8

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Docker build #8

merged 1 commit into from
Apr 15, 2021

Conversation

kleo
Copy link
Member

@kleo kleo commented Apr 14, 2021

Instructions for building with Docker environment included in README.md

@nickdesaulniers
Copy link
Member

cool, thanks!

I don't like the inconsistency between instructions for Docker, vs some on the wiki https://github.com/linux-3ds/arm9linuxfw/wiki. How about you point people to the wiki from the readme, then update the readme after the Dockerfile lands?

@kleo
Copy link
Member Author

kleo commented Apr 15, 2021

I removed the instructions on readme. You can add them on wiki or you can let me write it for you

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, are you able to edit the wiki or do we need to add you to the org?

@nickdesaulniers nickdesaulniers merged commit 7fbd781 into linux-3ds:master Apr 15, 2021
@nickdesaulniers
Copy link
Member

@Wolfvak can help with org invites

@kleo
Copy link
Member Author

kleo commented Apr 15, 2021

SGTM, are you able to edit the wiki or do we need to add you to the org?

I think you need to add me to the org

@kleo kleo deleted the docker branch April 18, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants