Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module fails to build for Linux 6.5: detected write beyond size of object #49

Closed
alexmyczko opened this issue Aug 6, 2023 · 3 comments
Closed

module fails to build for Linux 6.5: detected write beyond size of object #49

alexmyczko opened this issue Aug 6, 2023 · 3 comments

Comments

@alexmyczko
Copy link

Thank you for considering:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043112
eafer added a commit that referenced this issue Aug 9, 2023
@eafer
Convert all strcpy() to strscpy()
5c4773c 
The build appears to be broken for some configurations on the Linux 6.5
release candidate:

  #49

Some sort of static overflow check is going on for strcpy(), and several
of my calls are triggering false positives. Just be safe and switch them
all to strscpy(). The qstr stuff in particular looked a bit too weird
anyway.

Signed-off-by: Ernesto A. Fernández <ernesto@corellium.com>
eafer added a commit that referenced this issue Aug 9, 2023
@eafer
Update FMODE_* stuff for the 6.5 kernel
bc2be91 
The build is broken for the Linux 6.5 release candidate:

  #49

The fmode_t type can no longer be used for block open flags, and we must
switch to blk_mode_t instead. FMODE_EXCL is no longer needed, since just
having a holder already implies it, but this requires a change to the
blkdev_put() api. There is also a new argument to blkdev_get_by_path()
which can be safely ignored. And finally, sb->s_mode is gone, but it
doesn't seem to make any difference.

Update all the code to the new apis.

Signed-off-by: Ernesto A. Fernández <ernesto@corellium.com>
@eafer
Copy link
Member

eafer commented Aug 9, 2023

I just pushed two patches that should fix this, but I don't see the strcpy() error over here (I'm guessing it's a configuration option I'm not using), so let me know if it's still broken somehow.

@eafer
Copy link
Member

eafer commented Aug 15, 2023

I just made a release, so I guess I can close this.

@eafer eafer closed this as completed Aug 15, 2023
@daniele-athome
Copy link

daniele-athome commented Sep 24, 2023 •
edited

This is still present on Debian testing with kernel 6.5.0 (using apfs from unstable which is 0.3.3+git20230810+ds-1 (meaning it was probably built from git at that date). I see another commit after that and another release though.

EDIT: using the latest release did build successfully, so I guess it's a Debian problem now :-) I'll notify downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniele-athome @alexmyczko @eafer