Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert libaudit field parsing code to use macros instead of hard-coded error numbers #11

Closed
rgbriggs opened this issue Apr 4, 2017 · 2 comments
Closed

Convert libaudit field parsing code to use macros instead of hard-coded error numbers #11

rgbriggs opened this issue Apr 4, 2017 · 2 comments
Assignees
@rgbriggs
Labels
enhancement priority/medium
Milestone
audit-2.7

Comments

@rgbriggs
Copy link
Member

rgbriggs commented Apr 4, 2017

The audit_rule_interfield_comp_data() and audit_rule_fieldpair_data() option field parsers use over 30 hard-coded numerical error codes to select an error message when errors are detected. Use meaningfully named macros to make the code easier to understand and verify.
@rgbriggs rgbriggs added this to the audit-2.7 milestone Apr 4, 2017
@rgbriggs rgbriggs self-assigned this Apr 4, 2017
@rgbriggs
Copy link
Member Author

rgbriggs commented Apr 4, 2017

Patch posted upstream: https://www.redhat.com/archives/linux-audit/2017-April/msg00004.html

@stevegrubb
Copy link
Member

applied

rgbriggs added a commit to rgbriggs/audit-userspace that referenced this issue May 7, 2017
@rgbriggs
errormsg: convert all raw error codes in table to macro values
50a25fa 
Use the newly created error code macros in the error code text translation table.

See: linux-audit#11

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
stevegrubb pushed a commit that referenced this issue Jun 13, 2017
@rgbriggs @RH-steve-grubb
errormsg: convert all raw error codes in table to macro values
b389789 
Use the newly created error code macros in the error code text translation table.

See: #11

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
@e06620227 e06620227 mentioned this issue May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgbriggs rgbriggs

Labels
enhancement priority/medium
Projects
None yet
Milestone
audit-2.7
Development

No branches or pull requests
2 participants
@rgbriggs @stevegrubb