Merge pull request #22 from fiurin/topic/review-text

Fix multiple text issues
linux-automation · May 25, 2023 · 3be950e · 3be950e
2 parents 8232cf2 + 9af7286
commit 3be950e
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 19 deletions.
diff --git a/openapi.yaml b/openapi.yaml
@@ -2,7 +2,7 @@ openapi: 3.0.3
 
 info:
   title: LXA TAC HTTP API
-  description: Control and view inputs and outputs of you LXA TAC
+  description: Control and view inputs and outputs of your LXA TAC
   version: 0.1.0
 
 paths:
@@ -129,7 +129,7 @@ paths:
 
   /v1/dut/powered:
     get:
-      summary: Get the current Power Switch state
+      summary: Get the current power switch state
       tags: [DUT Power]
       responses:
         '200':
@@ -141,7 +141,7 @@ paths:
     put:
       summary: Try to set the power switch state
       description: >
-        While the request will return immediately with a sucessful response, this does not mean
+        While the request will return immediately with a successful response, this does not mean
         that the switch is actually on at this or a later point in time.
         You will always have to check with e.g. a GET request if you really want to know, as an
         error state could always take precedence.
@@ -259,7 +259,7 @@ paths:
 
   /v1/tac/setup_mode:
     get:
-      summary: Check if the TAC has completed the set up or still in setup mode
+      summary: Check if the TAC has completed the set up or is still in setup mode
       tags: [System]
       responses:
         '200':
@@ -366,7 +366,7 @@ paths:
   /v1/output/{out_n}/asserted:
     parameters:
       - name: out_n
-        description: The name of the output to get or modify
+        description: The name of the output, that shall be asserted
         required: true
         schema:
           type: string
@@ -710,7 +710,7 @@ paths:
         '204':
           description: The value was parsed as string and will be tried
         '400':
-          description: The value could not be parsed as boolean
+          description: The value could not be parsed as string
 
   /v1/tac/network/hostname:
     get:

diff --git a/src/ui/screens/reboot.rs b/src/ui/screens/reboot.rs
@@ -49,7 +49,7 @@ fn rly(draw_target: &mut FramebufferDrawTarget) {
     let text_style: MonoTextStyle<BinaryColor> = MonoTextStyle::new(&UI_TEXT_FONT, BinaryColor::On);
 
     Text::with_alignment(
-        "Really reboot?\nLong press to confirm",
+        "Really reboot?\nLong press lower\nbutton to confirm.",
         Point::new(120, 120),
         text_style,
         Alignment::Center,

diff --git a/src/ui/screens/setup.rs b/src/ui/screens/setup.rs
@@ -150,7 +150,7 @@ impl MountableScreen for SetupScreen {
                 Point::new(120, 55),
                 Box::new(|connectivity| match connectivity {
                     Connectivity::Nothing => {
-                        "Welcome to your TAC!\n\n\nPlease connect\nto a network\nto continue\n the setup".into()
+                        "Welcome to your TAC!\n\n\nPlease connect\nto a network\nto continue\nthe setup".into()
                     }
                     Connectivity::HostnameOnly(c) | Connectivity::IpOnly(c) => {
                         format!("Welcome to your TAC!\n\nPlease continue the\nsetup at:\n\n\nhttp://{c}")

diff --git a/web/src/DashboardDut.tsx b/web/src/DashboardDut.tsx
@@ -150,7 +150,7 @@ export default function DashboardDut() {
         header={
           <Header
             variant="h2"
-            description="Set bootmodes or reset the DUT via jumper pins"
+            description="Set boot modes or reset the DUT via jumper pins"
           >
             Isolated Outputs
           </Header>
@@ -202,11 +202,15 @@ export default function DashboardDut() {
                     <>
                       <p>
                         The OUT_{port} voltage is measured between the two OUT_
-                        {port} pins. As the two pins can generally be used
-                        interchangeably, you will most likely not care about the
-                        polarity of this voltage. This is why the absolute is
-                        shown in the bar graph and the text representation. If
-                        you want to see the polarity you can refer to the plots.
+                        {port} pins. The bar graph and the text representation
+                        show the absolute voltage, because the two pins can
+                        generally be used interchangeably and we assume, that
+                        you will most likely not care about the polarity of this
+                        voltage.
+                      </p>
+                      <p>
+                        However, if you want to see the polarity you can refer
+                        to the plots.
                       </p>
                       <p>
                         The voltages on the OUT_{port} pins is isolated from the

diff --git a/web/src/LandingPage.tsx b/web/src/LandingPage.tsx
@@ -65,7 +65,7 @@ export default function LandingPage() {
           {
             name: "Settings / Labgrid",
             href: "/#/settings/labgrid",
-            description: "Modify the Labgrid exporter config",
+            description: "Modify the labgrid exporter config",
           },
           {
             name: "Documentation / REST API",

diff --git a/web/src/SettingsLabgrid.tsx b/web/src/SettingsLabgrid.tsx
@@ -81,7 +81,7 @@ export default function SettingsLabgrid() {
         header={
           <Header
             variant="h2"
-            description="Restart the Labgrid exporter service and view its log"
+            description="Restart the labgrid exporter service and view its log"
           >
             Labgrid Exporter Status
           </Header>

diff --git a/web/src/Setup.tsx b/web/src/Setup.tsx
@@ -217,7 +217,7 @@ function SshWizard(props: WizardProps) {
           },
           {
             title: "Configure Labgrid",
-            description: "Configure your Labgrid Exporter",
+            description: "Configure your labgrid Exporter",
             isOptional: true,
             content: (
               <Container>
@@ -227,7 +227,7 @@ function SshWizard(props: WizardProps) {
           },
           {
             title: "Test Labgrid",
-            description: "Make sure your Labgrid Exporter Service looks healty",
+            description: "Make sure your labgrid Exporter Service looks healty",
             isOptional: true,
             content: (
               <Container>

diff --git a/web/src/TacComponents.tsx b/web/src/TacComponents.tsx
@@ -138,7 +138,7 @@ export function RaucSlotStatus() {
           header={
             <Header
               variant="h3"
-              description="The root filesystem contains your applications and settings"
+              description="The root file system contains your applications and settings"
             >
               Root Filesystem Slots
             </Header>