Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMT-M373NT to rules to allow it to connect #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thp
Copy link
Collaborator

@thp thp commented Apr 21, 2022

Collecting some random patches from the web (this was also at glaubitz#3).

@glaubitz
Copy link
Collaborator

Looks good to me.

@karcherm
Copy link
Collaborator

Unfortunately, we have the list of USB device IDs for NetMD devices in multiple places. Please also add the device ID to netmd/libnetmd.py . We already have the ID in libnetmd/netmd_dev.c , so no change required there.

@thp
Copy link
Collaborator Author

thp commented Apr 28, 2022

That's true. There are also some more outdated places that need to be updated when devices are added.

In my friendly fork (which I'll try to get merged upstream eventually) there's a single place to update it (devicedb/minidisc.devids), it generates a udev rules file and data for libusbmd (which is a small library that allows e.g. libnetmd and QHiMDTransfer to share that information from a single place).

It also writes out the database as netmd-js compatible file (not used yet, but once this is merged, maybe we can get the maintainers to use/copy that file) and the Python netmd implementation (since it's kind of nice that it's self-contained, we could use ctypes to load libusbmd, but that'd require it to be built, etc...).

https://github.com/thp/linux-minidisc/tree/minidisc-ffwd/devicedb

Adding device with that mechanism still involves a diff in multiple places:

thp@b1c5562

But the way this is achieved is simple:

  1. Add the entry to devicedb/minidisc.devids
  2. Run make -C devicedb
  3. Commit the result

So feel free to close this PR for now, and we'll "fix it properly" with the devicedb and libusbmd changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants