Indicate the progress of flashing for better user experience. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firehose.c
Outdated
| @@ -401,6 +403,9 @@ static int firehose_program(struct qdl_device *qdl, struct program *program, int | |||
| lseek(fd, (off_t) program->file_offset * program->sector_size, SEEK_SET); | |||
| left = num_sectors; | |||
| while (left > 0) { | |||
| fprintf(stderr, "[PROGRAM] %d sectors remaining out of %d (%.2f%%)\r", | |||
There was a problem hiding this comment.
I was thinking that we didn't want to update this too often, but with the typical 1MB max_payload_size, and if my math is correct, this will generate about 10kb of logs per second on my machine. So, I don't think we need to make this more fancy at this time.
I'm thinking that we should clean up the logs a bit in general. Until then, I like this patch!
But perhaps move it last in the loop? That way it will end at 100%.
There was a problem hiding this comment.
For larger images QDL appear to be stuck without any logs. So updated the patch to limit to 1 log per second. Do check if this is fine.
Add logs to show the partition label currently being flashed and amount of progress as a percentage of completion. Signed-off-by: Viswanath Kraleti <quic_vkraleti@quicinc.com>
quic-vkraleti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logs to firehose to show the partition label currently being flashed and progress as a percentage of completion.