ndef: Fix text payloads getting truncated. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed commit description to <72 char lines. |
|
New commit should compile without emitting a format warning. |
|
The previous commit was not merged, so please correct it instead of creating one more. IOW, squash it to previous commit. |
krzk
requested changes
Jun 27, 2024
|
10th time's the charm. Hopefully this PR is acceptable. I apologize for my previous mistakes, I have very little experience in contributing to upstream projects. Thank you guys for all you do. |
krzk
requested changes
Jul 1, 2024
Change "len" from uint8_t to int so it can accurately represent the full size of a text payload greater than 255 characters.
|
I just now added the message. I figured the title was descript enough, no detailed message needed; I'm guessing no detailed message breaks protocol? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text payloads larger than ~200 characters in length get truncated due
to the variable 'len' being uint8_t. Changing it to uint32_t fixes
this issue, allowing the whole text payload to be extracted.