nvme connect will be failed if no /etc/nvme/hostnqn

[yizhanglinux]

Hello
With the latest nvme-cli, the nvme connect will be failed when there is no /etc/nvme/hostnqn, is that expected?
It works with the nvme-cli 1.x version.

nvme-cli/fabrics.c

Line 750 in 27eb620

if (!hostnqn)

$ git diff
diff --git a/fabrics.c b/fabrics.c
index ef80ec0..1f5460f 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -749,10 +749,14 @@ int nvmf_connect(const char *desc, int argc, char **argv)
 
        if (!hostnqn)
                hostnqn = hnqn = nvmf_hostnqn_from_file();
+       fprintf(stderr, "hnqn: %s\n", hnqn);
+       fprintf(stderr, "hostnqn: %s\n", hostnqn);
        if (!hostid)
                hostid = hid = nvmf_hostid_from_file();
        h = nvme_lookup_host(r, hostnqn, hostid);
        if (!h) {
+               fprintf(stderr, "nvme_lookup_host: failed: hnqn: %s\n", hnqn);
+               fprintf(stderr, "nvme_lookup_host: failed: hostnqn: %s\n", hostnqn);
                errno = ENOMEM;
                goto out_free;
        }
$ .build/nvme connect -t loop -n blktests-subsystem-1 
hnqn: (null)
hostnqn: (null)
nvme_lookup_host: failed: hnqn: (null)
nvme_lookup_host: failed: hostnqn: (null)

[igaw]

I think the 1.x version called nvmf_hostnqn_file() -> hostnqn_read() which tried to read the hosnqn from /etc/nvme/hostnqn and if this failed it tried hostnqn_read_dmi and eventually hostnqn_generate_systemd as fallback. I think we could do the same approach here.