Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme-create-ns.txt Has conflicting info between synopsis and options #86

Closed
TaylorSanchez opened this issue May 16, 2016 · 2 comments
Closed

Comments

@TaylorSanchez
Copy link

Is the shorthand for --nsze supposed to be -n or -s?

Synopsis
'nvme create-ns' [--nsze= | -n ]

Options
-s::
--nsze::
https://guides.github.com/features/mastering-markdown/
The namespace size.

It appears -s is the correct one, when looking at nvme.c:
https://github.com/linux-nvme/nvme-cli/blob/master/nvme.c :
{"nsze", 's', "NUM", CFG_LONG_SUFFIX, &cfg.nsze, required_argument, nsze},

keithbusch pushed a commit that referenced this issue May 16, 2016
It's -s, not -n.

Issue: #86
Signed-off-by: Keith Busch <keith.busch@intel.com>
@keithbusch
Copy link
Contributor

It's -s; the man page is wrong. The '-n' option commonly refers to "namespace" in the rest of the possible sub-arguments, so used 's' for size in this command.

Thanks for the report, will fix shortly.

@keithbusch
Copy link
Contributor

Fixed: 402a87b

davidsaOpenu pushed a commit to davidsaOpenu/nvme-cli that referenced this issue Sep 2, 2016
It's -s, not -n.

Issue: linux-nvme#86
Signed-off-by: Keith Busch <keith.busch@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants