Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect minimum and maximum fan speeds #137

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

gaul
Copy link
Member

@gaul gaul commented Aug 29, 2017

Default to previous values if detection fails. Configuration can
still override these values. Fixes #114.

@sasanj
Copy link

sasanj commented Aug 30, 2017

I think we need to add an option to mpbfan to output a configuration file, based on these detected values.
This way, make install becomes smarter, and addresses the issue #114 way better.

@gaul
Copy link
Member Author

gaul commented Sep 1, 2017

Ideally mbpfan should work without any configuration file. I plan a subsequent commit which will make intelligent decisions about the temperatures.

@dgraziotin
Copy link
Collaborator

Currently on vacation. Will try to review all these PR by the end of the month. I would like more the generation of a config file than to go config-less. Still give power to end user to override.

@gaul
Copy link
Member Author

gaul commented Sep 1, 2017

Agree that the user should be able to override the defaults, but I would like the defaults to be dynamic instead of static as today.

@dgraziotin
Copy link
Collaborator

@gaul how about having a flag to create a default config file instead? That would use your smart detection system and would make the user more aware of what is going on.
Anyway, this is candidate for a 2.1.x release.

@gaul
Copy link
Member Author

gaul commented Oct 4, 2017

mbpfan should not need a config file for typical users and only use it for unusual situations. macOS users do not need a config file to get reasonable behavior from their fans!

@gaul
Copy link
Member Author

gaul commented Aug 20, 2018

@dgraziotin I would like to merge this; any objections?

@gaul gaul mentioned this pull request Aug 20, 2018
3 tasks
@gaul
Copy link
Member Author

gaul commented Aug 20, 2018

Unfortunately Better Code Hub does not allow me to view this error:

Only the repository's owners and organization members (if the repository is an organization repository) can view its Better Code Hub results.

@dgraziotin Perhaps you can configure open access somehow?

@dgraziotin
Copy link
Collaborator

@gaul I will take a look. Isn't BCH not suitable for C, though? I will look whether I can make the results open for anyone

@gaul
Copy link
Member Author

gaul commented Aug 21, 2018

@gaul I will take a look. Isn't BCH not suitable for C, though? I will look whether I can make the results open for anyone

Sorry I don't understand what is BCH?

Default to previous values if detection fails.  Configuration can
still override these values.  Fixes linux-on-mac#114.
@gaul gaul merged commit 810adc6 into linux-on-mac:master Aug 28, 2018
@gaul gaul deleted the min-max-fan-speed branch August 28, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants