Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Fedora Package #181 #209

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Official Fedora Package #181 #209

merged 1 commit into from
Jan 12, 2020

Conversation

LyesSaadi
Copy link

mbpfan is finally on official Fedora repository 馃帀!

@LyesSaadi LyesSaadi changed the title Offcial Fedora Package #181 Official Fedora Package #181 Jan 12, 2020
@gaul gaul merged commit dd4ed65 into linux-on-mac:master Jan 12, 2020
@gaul
Copy link
Member

gaul commented Jan 12, 2020

Thank you for your hard work! I noticed two things when installing on my MacBook:

  • mbpfan did not start automatically after dnf install mbpfan. Does this start automatically on reboot? Can it start automatically after install?
  • I noticed it runs as /usr/sbin/mbpfan -f. Is this the convention for systemd instead of daemonizing?

@LyesSaadi
Copy link
Author

LyesSaadi commented Jan 12, 2020

Thank you for your hard work!

You're welcome :)!

mbpfan did not start automatically after dnf install mbpfan. Does this start automatically on reboot?

No, I would have to go through a special request for that according to policy. But, does mbpfan 芦 alter other services 禄 by taking over the fans? If not, would you want me to go through the process?

Can it start automatically after install?

No, for reasons explained here.

I noticed it runs as /usr/sbin/mbpfan -f. Is this the convention for systemd instead of daemonizing?

Yep, for logs when doing systemctl status mbpfan. And, well, I'm using the provided systemd service.

Also, thank you for being patient and allowing me to be your Fedora maintainer for mbpfan :).

@gaul
Copy link
Member

gaul commented Jan 12, 2020

No, I would have to go through a special request for that according to policy. But, does mbpfan 芦 alter other services 禄 by taking over the fans? If not, would you want me to go through the process?

This sounds reasonable. Should the README or the post-install script suggest how to start mbpfan automatically?

Also, thank you for being patient and allowing me to be your Fedora maintainer for mbpfan :).

Thank you for bringing mbpfan to a wider audience!

@LyesSaadi
Copy link
Author

This sounds reasonable.

So, do you want me to go through the process? I'm confused :/. What does sound reasonable, Fedora policy or going through the process :P. Please also bear in mind that only some services are enabled by default and none of them are hardware-dependent.

Should the README or the post-install script suggest how to start mbpfan automatically?

The README, as post-install scripts do not display any message with DNF. And there's already a section for that :)!

@gaul
Copy link
Member

gaul commented Jan 13, 2020

Let's not do anything special for Fedora. However I would like the instructions to be straightforward for beginning users who may not understand systemd. Looking at the README, it seems like the instructions may be stale for a few distributions. At least the Fedora section should suggest the systemd instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants