pam_exec: arggv not free'd on error

[setharnold]

linux-pam/modules/pam_exec/pam_exec.c

Line 416 in 2f28987

arggv = calloc (argc + 4, sizeof (char *));

Hello, the arggv array and referenced strings aren't free'd on any of the error paths. This is probably not a big deal but does seem out of character given other things are free'd in the same error paths.

Thanks

[ldv-alt]

Thanks for reporting.
I think freeing memory right before pam_syslog() followed by _exit(ENOMEM) is rather useless,
so wouldn't it be better to remove all those free(envlist) calls instead?

What's worse is the unchecked return value of strdup in

linux-pam/modules/pam_exec/pam_exec.c

Line 421 in 2f28987

arggv[i] = strdup(argv[i+optargc]);

[setharnold]

Heh, I thought about that, too, but it's nice to clean up memory before exit() to keep valgrind reports short and sweet. It's up to you what you'd rather do, but I'd argue for consistency either way.

I can't believe I looked right past that unchecked strdup() though. Sigh.

Thanks

[ldv-alt]

@thkukuk Thorsten, I think it's your code, would you prefer freeing arggv[] array before _exit() calls, or removing free(envlist) calls?

[thkukuk]

It's not only arggv which is not free'd, but freeing envlist also leaves a lot of unreachable allocations behind.
So before we write long, complex code to free all kind of memory, just remove free(envlist).