Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #774

Closed
mani3029 opened this issue Mar 1, 2024 · 8 comments
Closed

New release #774

mani3029 opened this issue Mar 1, 2024 · 8 comments
Labels

Comments

@mani3029
Copy link

mani3029 commented Mar 1, 2024

Hi Team,
Released 1.6.0 code compilation fails due to missing header files in pam_namespace.c (https://github.com/linux-pam/linux-pam/blob/v1.6.0/modules/pam_namespace/pam_namespace.c), below is the error
pam_namespace.c: In function 'process_line': pam_namespace.c:649:41: error: 'SIZE_MAX' undeclared (first use in this function); did you mean 'SSIZE_MAX'? if (count > UINT_MAX || count > SIZE_MAX / sizeof(uid_t)) { ^~~~~~~~ SSIZE_MAX pam_namespace.c:649:41: note: each undeclared identifier is reported only once for each function it appears in Makefile:796: recipe for target 'pam_namespace.lo' failed make[6]: *** [pam_namespace.lo] Error 1

Changes have been pushed in master branch .
cc9d40b
When can we expect next version release with above code inclusion ?

@mani3029
Copy link
Author

mani3029 commented Mar 4, 2024

hi @ldv-alt any input/plan on this ?

@mani3029
Copy link
Author

hi team any update ?

@thkukuk
Copy link
Contributor

thkukuk commented Mar 14, 2024

Updates will be made if somebody has time and all regressions are fixed or a serious issue is found (compile problems for a few people easy to fix themself are not serious issues). For the time being: take the patch and apply it locally to compile Linux-PAM.

@ldv-alt
Copy link
Member

ldv-alt commented Mar 25, 2024

I'd like to sort out #758 before the next release.

@ldv-alt ldv-alt changed the title 1.6.0 compilation fails due to missing header in pam_namespace.c New release Apr 2, 2024
@ldv-alt
Copy link
Member

ldv-alt commented Apr 2, 2024

Given that all known regressions introduced in v1.6.0 are now fixed, let's have a new release so that more users could benefit from it. Let's do it on some Tuesday of April, say, on 9th.

@ikerexxe @stoeckmann @t8m @thkukuk, What do you think about it?

@thkukuk
Copy link
Contributor

thkukuk commented Apr 2, 2024

I agree, we should do that now.

@ikerexxe
Copy link
Contributor

ikerexxe commented Apr 2, 2024

Sounds good to me

@stoeckmann
Copy link
Contributor

I fully agree as well.

@ldv-alt ldv-alt closed this as completed in 9438e08 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants