Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git tags are not consistent #5

Closed
cyrilleverrier opened this issue Oct 2, 2018 · 2 comments
Closed

git tags are not consistent #5

cyrilleverrier opened this issue Oct 2, 2018 · 2 comments

Comments

@cyrilleverrier
Copy link
Contributor

I noticed that the latest git tag is 3.3.21
This is not consistent with the other git tags in this repo, like opensm-3.3.20

I wrote a script that relies on the convention that all tags in the opensm repo starts with opensm- to fetch the correct version.
Would you be kind enough to add the following git tag: opensm-3.3.21

Thank you.
@hnrose
Copy link
Contributor

hnrose commented Oct 2, 2018 •
edited
Loading

I noticed that the latest git tag is 3.3.21
This is not consistent with the other git tags in this repo, like opensm-3.3.20

When switching over to github, there was issue with labels in terms of release so the opensm- needed to be dropped. See ##1

I wrote a script that relies on the convention that all tags in the opensm repo starts with opensm- to fetch the correct version.

Can you update your script based on the change in the tag naming scheme ?

Would you be kind enough to add the following git tag: opensm-3.3.21
Thank you.

@cyrilleverrier
Copy link
Contributor Author

Thank you @hnrose for your explanation.

I will update my script base on the new naming scheme

hnrose pushed a commit that referenced this issue Nov 30, 2018
osm_opensm.c: Fix seg fault in destroy_routing_engines
73f6461 
Core was generated by `/usr/sbin/opensm -F /opt/wd/i'.
Program terminated with signal 6, Aborted.
 #0  0x000000394e632925 in raise () from /lib64/libc.so.6
 #0  0x000000394e632925 in raise () from /lib64/libc.so.6
 #1  0x000000394e634105 in abort () from /lib64/libc.so.6
 #2  0x000000394e670837 in __libc_message () from /lib64/libc.so.6
 #3  0x000000394e676166 in malloc_printerr () from /lib64/libc.so.6
 #4  0x0000000000431b56 in destroy_routing_engines (osm=0x7fff01bddbb0) at osm_opensm.c:284
 #5  0x0000000000431cc0 in osm_opensm_destroy (p_osm=0x7fff01bddbb0) at osm_opensm.c:343
 #6  0x000000000040dadd in main (argc=3, argv=0x7fff01c0c268) at main.c:1280

Fixes: 7f98069 ("osm_opensm.c: destroy_routing_engines should destroy the default routing engine")
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hnrose @cyrilleverrier