riscv: Remove duplicate objcopy flag #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
for-next_base
branch
from
457c5c4
to
90cc0d3
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
a2b91db
to
76eadb5
Compare
bjoto
force-pushed
the
for-next_base
branch
from
90cc0d3
to
5a6f47f
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
76eadb5
to
2f0dd88
Compare
bjoto
force-pushed
the
for-next_base
branch
from
5a6f47f
to
37369a9
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
2f0dd88
to
aeae774
Compare
bjoto
force-pushed
the
for-next_base
branch
from
37369a9
to
30e3469
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
aeae774
to
b19f3cc
Compare
bjoto
force-pushed
the
for-next_base
branch
from
30e3469
to
aaa72bf
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
b19f3cc
to
e9c1eb2
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
e9c1eb2
to
8cab564
Compare
|
Upstream branch: 0bb80ec |
bjoto
force-pushed
the
series/784083=>for-next
branch
from
8cab564
to
aae0388
Compare
|
Upstream branch: 0bb80ec |
There are two duplicate `-O binary` flags when objcopying from vmlinux to Image/xipImage. RISC-V set `-O binary` flag in both OBJCOPYFLAGS in the top-level riscv Makefile and OBJCOPYFLAGS_* in the boot/Makefile, and the objcopy cmd in Kbuild would join them together. The `-O binary` flag is only needed for objcopying Image, so remove the OBJCOPYFLAGS in the top-level riscv Makefile. Fixes: c0fbcd9 ("RISC-V: Build flat and compressed kernel images") Signed-off-by: Song Shuai <songshuaishuai@tinylab.org> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
bjoto
force-pushed
the
series/784083=>for-next
branch
from
aae0388
to
ba00a10
Compare
|
At least one diff in series https://patchwork.kernel.org/project/linux-riscv/list/?series=784083 irrelevant now. Closing PR. |
bjoto
pushed a commit
that referenced
this pull request
Jan 4, 2024
As of commit b92143d ("net: dsa: mv88e6xxx: add infrastructure for phylink_pcs") probing of a Marvell 88e6350 switch causes a NULL pointer de-reference like this example: ... mv88e6085 d0072004.mdio-mii:11: switch 0x3710 detected: Marvell 88E6350, revision 2 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address 00000000 when read [00000000] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: CPU: 0 PID: 8 Comm: kworker/u2:0 Not tainted 6.7.0-rc2-dirty #26 Hardware name: Marvell Armada 370/XP (Device Tree) Workqueue: events_unbound deferred_probe_work_func PC is at mv88e6xxx_port_setup+0x1c/0x44 LR is at dsa_port_devlink_setup+0x74/0x154 pc : [<c057ea24>] lr : [<c0819598>] psr: a0000013 sp : c184fce0 ip : c542b8f4 fp : 00000000 r10: 00000001 r9 : c542a540 r8 : c542bc00 r7 : c542b838 r6 : c5244580 r5 : 00000005 r4 : c5244580 r3 : 00000000 r2 : c542b840 r1 : 00000005 r0 : c1a02040 ... The Marvell 6350 switch has no SERDES interface and so has no corresponding pcs_ops defined for it. But during probing a call is made to mv88e6xxx_port_setup() which unconditionally expects pcs_ops to exist - though the presence of the pcs_ops->pcs_init function is optional. Modify code to check for pcs_ops first, before checking for and calling pcs_ops->pcs_init. Modify checking and use of pcs_ops->pcs_teardown which may potentially suffer the same problem. Fixes: b92143d ("net: dsa: mv88e6xxx: add infrastructure for phylink_pcs") Signed-off-by: Greg Ungerer <gerg@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
bjoto
pushed a commit
that referenced
this pull request
Jan 11, 2024
With previous patch, one of subtests in test_btf_id becomes flaky and may fail. The following is a failing example: Error: #26 btf Error: #26/174 btf/BTF ID Error: #26/174 btf/BTF ID btf_raw_create:PASS:check 0 nsec btf_raw_create:PASS:check 0 nsec test_btf_id:PASS:check 0 nsec ... test_btf_id:PASS:check 0 nsec test_btf_id:FAIL:check BTF lingersdo_test_get_info:FAIL:check failed: -1 The test tries to prove a btf_id not available after the map is closed. But btf_id is freed only after workqueue and a rcu grace period, compared to previous case just after a rcu grade period. Depending on system workload, workqueue could take quite some time to execute function bpf_map_free_deferred() which may cause the test failure. Instead of adding arbitrary delays, let us remove the logic to check btf_id availability after map is closed. Signed-off-by: Yonghong Song <yonghong.song@linux.dev> Link: https://lore.kernel.org/r/20231214203820.1469402-1-yonghong.song@linux.dev Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: riscv: Remove duplicate objcopy flag
version: 1
url: https://patchwork.kernel.org/project/linux-riscv/list/?series=784083