Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently prefer sysfs/json events #878

Closed
wants to merge 16 commits into from
Closed

Consistently prefer sysfs/json events #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8554ddb
perf parse-events: Factor out '<event_or_pmu>/.../' parsing
captain5050 Apr 16, 2024
cf782ea
perf parse-events: Directly pass PMU to parse_events_add_pmu
captain5050 Apr 16, 2024
d83931e
perf parse-events: Avoid copying an empty list
captain5050 Apr 16, 2024
1f8829e
perf pmu: Refactor perf_pmu__match
captain5050 Apr 16, 2024
f85bce3
perf tests parse-events: Use branches rather than cache-references
captain5050 Apr 16, 2024
1df3dcb
perf parse-events: Legacy cache names on all PMUs and lower priority
captain5050 Apr 16, 2024
1029687
perf parse-events: Handle PE_TERM_HW in name_or_raw
captain5050 Apr 16, 2024
b0992fd
perf parse-events: Constify parse_events_add_numeric
captain5050 Apr 16, 2024
f74a903
perf parse-events: Prefer sysfs/json hardware events over legacy
captain5050 Apr 16, 2024
873deeb
perf parse-events: Inline parse_events_update_lists
captain5050 Apr 16, 2024
362e67e
perf parse-events: Improve error message for bad numbers
captain5050 Apr 16, 2024
cd0fbdf
perf parse-events: Inline parse_events_evlist_error
captain5050 Apr 16, 2024
1984ded
perf parse-events: Improvements to modifier parsing
captain5050 Apr 16, 2024
11ce57a
perf parse-event: Constify event_symbol arrays
captain5050 Apr 16, 2024
1f3611a
perf parse-events: Minor grouping tidy up
captain5050 Apr 16, 2024
15a8cde
perf parse-events: Tidy the setting of the default event name
captain5050 Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/perf/tests/parse-events.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,8 +953,8 @@ static int test__group2(struct evlist *evlist)
continue;
}
if (evsel->core.attr.type == PERF_TYPE_HARDWARE &&
test_config(evsel, PERF_COUNT_HW_CACHE_REFERENCES)) {
/* cache-references + :u modifier */
test_config(evsel, PERF_COUNT_HW_BRANCH_INSTRUCTIONS)) {
/* branches + :u modifier */
TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user);
TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel);
TEST_ASSERT_VAL("wrong exclude_hv", evsel->core.attr.exclude_hv);
Expand Down Expand Up @@ -2043,7 +2043,7 @@ static const struct evlist_test test__events[] = {
/* 8 */
},
{
.name = "{faults:k,cache-references}:u,cycles:k",
.name = "{faults:k,branches}:u,cycles:k",
.check = test__group2,
/* 9 */
},
Expand Down