Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init() #897

Closed
wants to merge 4 commits into from

Conversation

bjoto
Copy link

@bjoto bjoto commented Apr 18, 2024

Pull request for series with
subject: riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init()
version: 4
url: https://patchwork.kernel.org/project/linux-riscv/list/?series=845655

@bjoto
Copy link
Author

bjoto commented Apr 18, 2024

Upstream branch: ba5ea59
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=845655
version: 4

@bjoto
Copy link
Author

bjoto commented Apr 28, 2024

Upstream branch: 0a16a17
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=845655
version: 4

@bjoto
Copy link
Author

bjoto commented May 9, 2024

Upstream branch: 0a16a17
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto bjoto added V5 and removed V4 labels May 9, 2024
@bjoto bjoto force-pushed the series/845655=>for-next branch from 4a83182 to 1deb5e4 Compare May 9, 2024 07:38
@bjoto bjoto closed this May 14, 2024
@bjoto bjoto reopened this May 14, 2024
@bjoto
Copy link
Author

bjoto commented May 14, 2024

Upstream branch: 92cce91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto
Copy link
Author

bjoto commented May 15, 2024

Upstream branch: 5e3964b
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto
Copy link
Author

bjoto commented May 17, 2024

Upstream branch: 92cce91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto
Copy link
Author

bjoto commented May 22, 2024

Upstream branch: 018b9d9
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto
Copy link
Author

bjoto commented May 22, 2024

Upstream branch: 0bfbc91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: c6c901b
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851801
version: 5

@bjoto bjoto closed this May 23, 2024
@bjoto bjoto reopened this May 23, 2024
@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: 46cad6c
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=855300
version: 5

…f_init()

ci_leaf_init() is a declared static function. The implementation of the
function body and the caller do not use the parameter (struct device_node
*node) input parameter, so remove it.

Fixes: 6a24915 ("Revert "riscv: Set more data to cacheinfo"")
Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: 6ca445d
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=855300
version: 5

Before cacheinfo can be built correctly, we need to initialize level
and type. Since RISC-V currently does not have a register group that
describes cache-related attributes like ARM64, we cannot obtain them
directly, so now we obtain cache leaves from the ACPI PPTT table
(acpi_get_cache_info()) and set the cache type through split_levels.

Suggested-by: Jeremy Linton <jeremy.linton@arm.com>
Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
After adding ACPI support to populate_cache_leaves(), RISC-V can build
cacheinfo through the ACPI PPTT table, thus enabling the ACPI_PPTT
configuration.

Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
@bjoto bjoto force-pushed the for-next_base branch 3 times, most recently from 958bb3b to d0767d5 Compare May 27, 2024 13:45
@bjoto bjoto closed this May 27, 2024
@bjoto
Copy link
Author

bjoto commented May 27, 2024

Upstream branch: 6ca445d
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=855300
version: 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants