Define _GNU_SOURCE for sources using #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 0a16a17 |
Add the -D_GNU_SOURCE flag to KHDR_INCLUDES so that it is defined in a central location. 8092162 ("selftests/harness: remove use of LINE_MAX") introduced asprintf into kselftest_harness.h, which is a GNU extension and needs _GNU_SOURCE to either be defined prior to including headers or with the -D_GNU_SOURCE flag passed to the compiler. Fixes: 8092162 ("selftests/harness: remove use of LINE_MAX") Reported-by: kernel test robot <oliver.sang@intel.com> Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com Signed-off-by: Edward Liaw <edliaw@google.com> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE). Also, remove redefinitions of _GNU_SOURCE in the source code. Fixes: 8092162 ("selftests/harness: remove use of LINE_MAX") Reported-by: kernel test robot <oliver.sang@intel.com> Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com Signed-off-by: Edward Liaw <edliaw@google.com> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness dependencies (-D_GNU_SOURCE). Fixes: 8092162 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw <edliaw@google.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
_GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to prevent _GNU_SOURCE redefined warnings. Fixes: 8092162 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Edward Liaw <edliaw@google.com> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
-D_GNU_SOURCE can be de-duplicated here, as it is added by KHDR_INCLUDES. Signed-off-by: Edward Liaw <edliaw@google.com> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
|
Upstream branch: 0a16a17 |
bjoto
force-pushed
the
series/851358=>for-next
branch
from
aba586c
to
1d929e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Define _GNU_SOURCE for sources using
version: 2
url: https://patchwork.kernel.org/project/linux-riscv/list/?series=851358