-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv: dts: canaan: Unused devices cleanup #978
Conversation
Upstream branch: 0a16a17 |
Upstream branch: 92cce91 |
16ec893
to
c6c048d
Compare
Upstream branch: 5e3964b |
c6c048d
to
84f390a
Compare
Upstream branch: 92cce91 |
84f390a
to
f81d0d3
Compare
Upstream branch: 018b9d9 |
f81d0d3
to
5cdd69e
Compare
Upstream branch: 0bfbc91 |
5cdd69e
to
74f805f
Compare
Upstream branch: c6c901b |
74f805f
to
0c993eb
Compare
Upstream branch: 46cad6c |
0c993eb
to
4deb34a
Compare
Upstream branch: 6ca445d |
The SoC-specific k210.dtsi declares aliases for all four serial ports. However, none of the board-specific DTS files configure pin control for any but the first serial port, so the last three ports are not usable. Move the aliases node from the SoC-specific k210.dtsi to the board-specific DTS files, as these are really board-specific, and retain the sole port that is usable. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
It is considered good practice to disable on-SoC devices providing external I/O in the SoC-specific .dtsi, and enable them explicitly in the board-specific DTS files when actually wired-up and used. Hence: - Set the status of I/O devices in k210.dtsi to "disabled", - Override the status of used I/O devices in board-specific DTS files to "okay", - Drop unneeded status overrides in board DTS-specific files for the always-enabled pin controller. On e.g. MAiXBiT, this gets rid of an error message when probing the unused slave-only spi2 controller: dw_spi_mmio 50240000.spi: error -22: problem registering spi host dw_spi_mmio 50240000.spi: probe with driver dw_spi_mmio failed with error -22 which is seen since commit 98d75b9 ("spi: dw: Drop default number of CS setting"). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
4deb34a
to
352b602
Compare
958bb3b
to
d0767d5
Compare
Upstream branch: 6ca445d |
Pull request for series with
subject: riscv: dts: canaan: Unused devices cleanup
version: 1
url: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513