Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: dts: canaan: Unused devices cleanup #978

Closed
wants to merge 3 commits into from

Conversation

bjoto
Copy link

@bjoto bjoto commented May 8, 2024

Pull request for series with
subject: riscv: dts: canaan: Unused devices cleanup
version: 1
url: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513

@bjoto
Copy link
Author

bjoto commented May 8, 2024

Upstream branch: 0a16a17
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 14, 2024

Upstream branch: 92cce91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 15, 2024

Upstream branch: 5e3964b
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 17, 2024

Upstream branch: 92cce91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 22, 2024

Upstream branch: 018b9d9
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 22, 2024

Upstream branch: 0bfbc91
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: c6c901b
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto bjoto closed this May 23, 2024
@bjoto bjoto reopened this May 23, 2024
@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: 46cad6c
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

@bjoto
Copy link
Author

bjoto commented May 23, 2024

Upstream branch: 6ca445d
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

The SoC-specific k210.dtsi declares aliases for all four serial ports.
However, none of the board-specific DTS files configure pin control for
any but the first serial port, so the last three ports are not usable.

Move the aliases node from the SoC-specific k210.dtsi to the
board-specific DTS files, as these are really board-specific, and retain
the sole port that is usable.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
It is considered good practice to disable on-SoC devices providing
external I/O in the SoC-specific .dtsi, and enable them explicitly in
the board-specific DTS files when actually wired-up and used.

Hence:
  - Set the status of I/O devices in k210.dtsi to "disabled",
  - Override the status of used I/O devices in board-specific DTS files
    to "okay",
  - Drop unneeded status overrides in board DTS-specific files for the
    always-enabled pin controller.

On e.g. MAiXBiT, this gets rid of an error message when probing the
unused slave-only spi2 controller:

    dw_spi_mmio 50240000.spi: error -22: problem registering spi host
    dw_spi_mmio 50240000.spi: probe with driver dw_spi_mmio failed with error -22

which is seen since commit 98d75b9 ("spi: dw: Drop default
number of CS setting").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
@bjoto bjoto force-pushed the for-next_base branch 3 times, most recently from 958bb3b to d0767d5 Compare May 27, 2024 13:45
@bjoto bjoto closed this May 27, 2024
@bjoto
Copy link
Author

bjoto commented May 27, 2024

Upstream branch: 6ca445d
series: https://patchwork.kernel.org/project/linux-riscv/list/?series=851513
version: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants