-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sunxi-tools 1.4 make fails when building meminfo #70
Comments
See pull request #71 |
Oh... I've never thought of invoking sunxi-tools # make -B sunxi-meminfo CROSS_COMPILE=armv7a-hardfloat-linux-gnueabi-
armv7a-hardfloat-linux-gnueabi-gcc -g -O0 -Wall -static -o sunxi-meminfo meminfo.c This is also what README.md states. Regards, NiteHawk |
Well yeah, but that's what TARGET_TOOLS is supposed to be for, right: To list tools which only work on the target... |
You're right - it took me a while to see all the implications. For those targets that have a single However the longer I look at it, the more I get the impression that we're lacking a dedicated rule for Fixing that (by adding a proper rule) will also mean that me might "suddenly" see build failures for systems where no cross-compiler is available, because so far the target-tools is part of the default Regards, NiteHawk |
Hi Danny! I'd like your feedback on this branch, especially the commit that alters the Makefile behaviour, related to the "breakage" concerns I expressed above. Would you be okay with solving it that way? Regards, NiteHawk |
Hi NiteHawk, I've tested the branch and it works. I see that it now leaves off useless-on-that-platform programs by default. Also, you added meminfo which is nice :) (I've had to help someone with memory stability problems (read: complete crashes) on his lime2. Also, apt-get install sunxi-tools did not install sunxi-meminfo. That was a really bad user experience) |
This appends sunxi-meminfo to the TARGET_TOOLS, and adds a new rule to fix the compilation of sunxi-pio (by making it *cross-compile* for the target). Additionally adds a new build target "make install-misc". For more details, see github issues linux-sunxi#69 and linux-sunxi#70. Signed-off-by: Bernhard Nortmann <bernhard.nortmann@web.de>
This appends sunxi-meminfo to the TARGET_TOOLS, and adds a new rule to fix the compilation of sunxi-pio (by making it *cross-compile* for the target). Additionally adds a new build target "make install-misc". For more details, see github issues linux-sunxi#69 and linux-sunxi#70. Signed-off-by: Bernhard Nortmann <bernhard.nortmann@web.de>
Thinking about it some more, gcc ... I realize that I was the one that suggested $< - I changed my mind :) . I think |
I'm fine with using And yes, |
This appends sunxi-meminfo to the TARGET_TOOLS, and adds a new rule to fix the compilation of sunxi-pio (by making it *cross-compile* for the target). Additionally adds a new build target "make install-misc". For more details, see github issues linux-sunxi#69 and linux-sunxi#70. Signed-off-by: Bernhard Nortmann <bernhard.nortmann@web.de>
Changes were merged. v1.4.1 should have resolved this issue. Regards, NiteHawk |
That is because we add Makefile, common.h and version.h as dependencies to all the tools (which I think is good).
However, the entry for sunxi-meminfo says:
sunxi-meminfo: meminfo.c $(CROSS_COMPILE)gcc -g -O0 -Wall -static -o $@ $^
And $^ will pass the Makefile to the compiler - which will barf.
I'd pass $<
Same for sunxi-script_extractor and sunxi-fel and the generic sunxi-% rule.
The text was updated successfully, but these errors were encountered: