media: ipu3-cio2: Re-add .complete() to ipu3-cio2 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the .complete() callback had some unintended consequences. Because the VCM driver is not directly linked to the ipu3-cio2 driver .bound() never gets called for it, which means its devnode is never created if it probes late. Because .complete() waits for any sub-notifiers to also be complete it is captured in that call. Signed-off-by: Daniel Scally <djrscally@gmail.com>
qzed
added a commit
to linux-surface/linux-surface
that referenced
this pull request
Jun 14, 2022
Changes: - Add support for tablet-mode switch on Surface Go (linux-surface/kernel#127, credits go to @krnhotwings) - Fix driver probe issues preventing cameras from working (linux-surface/kernel#128, credits go @djrscally) - Add support for more SAM events used by the Surface Laptop Studio. - Rebase onto v5.17.14 Links: - kernel: linux-surface/kernel@d973d23
qzed
added a commit
to linux-surface/linux-surface
that referenced
this pull request
Jun 14, 2022
Changes: - Add support for tablet-mode switch on Surface Go (linux-surface/kernel#127, credits go to @krnhotwings) - Fix driver probe issues preventing cameras from working (linux-surface/kernel#128, credits go @djrscally) - Add support for more SAM events used by the Surface Laptop Studio. - Rebase onto v5.18.3 Links: - kernel: linux-surface/kernel@d973d23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the always-broken VCMs and allow cameras to work again everywhere. The VCM itself may still not work - it will depend on probe ordering, I still need to fix the missing propagation for the -EPROBE_DEFER call in the cio2-bridge.
Sorry this took so long - I thought it was broken in some way as I couldn't get the focus to work but after extensive debugging it turned out I was just being an utter moron :D