Platform profile: switch fan profile #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
iwanders
force-pushed
the
platform_profile_switch_fan_profile
branch
from
54d09a8
to
274e706
Compare
|
I've marked this as ready for review. I cleaned up some comments here and there, and renamed the node in the registry. I've also squashed the commits and put a reasonable commit message / title on it. |
qzed
reviewed
Dec 29, 2023
qzed
reviewed
Dec 29, 2023
iwanders
force-pushed
the
platform_profile_switch_fan_profile
branch
from
274e706
to
1f32229
Compare
iwanders
commented
Dec 31, 2023
qzed
reviewed
Jan 3, 2024
iwanders
force-pushed
the
platform_profile_switch_fan_profile
branch
from
1f32229
to
5000708
Compare
Change naming from tmp to platform profile to clarify the module may interact with both the TMP and FAN subystems. Add functionality that switches the fan profile when the platform profile is changed. Signed-off-by: Ivor Wanders <ivor@iwanders.net>
iwanders
force-pushed
the
platform_profile_switch_fan_profile
branch
from
5000708
to
58baf8a
Compare
qzed
approved these changes
Mar 2, 2024
|
@StollD if you have some time, feel free to merge this and add it to the patches. Otherwise I'll try to make some time, but I'm not sure I can get to much before March 15th. |
|
Upstream lore entry for v1. |
|
I cherry-picked this to our 6.6 and 6.7 branches. Thank you! |
StollD
added a commit
to linux-surface/linux-surface
that referenced
this pull request
Mar 9, 2024
Changes: - Add driver for changing the fan profile (Surface Pro 9) Links: - kernel: linux-surface/kernel@fcc3a67 - fan profile driver: linux-surface/kernel#145
StollD
added a commit
to linux-surface/linux-surface
that referenced
this pull request
Mar 9, 2024
Changes: - Add driver for changing the fan profile (Surface Pro 9) - Added fixes for IPU3 cameras - Reverted DW9719 driver to previous version (Surface Go 2) Links: - kernel: linux-surface/kernel@530f557 - fan profile driver: linux-surface/kernel#145 - camera fixes: linux-surface/kernel#146
qzed
pushed a commit
that referenced
this pull request
Mar 31, 2024
Change naming from tmp to platform profile to clarify the module may interact with both the TMP and FAN subystems. Add functionality that switches the fan profile when the platform profile is changed when a fan is present. Signed-off-by: Ivor Wanders <ivor@iwanders.net> Link: #145 Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
qzed
pushed a commit
that referenced
this pull request
Mar 31, 2024
Change naming from tmp to platform profile to clarify the module may interact with both the TMP and FAN subystems. Add functionality that switches the fan profile when the platform profile is changed when a fan is present. Signed-off-by: Ivor Wanders <ivor@iwanders.net> Link: #145 Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
qzed
pushed a commit
that referenced
this pull request
Apr 1, 2024
Change naming from tmp to platform profile to clarify the module may interact with both the TMP and FAN subystems. Add functionality that switches the fan profile when the platform profile is changed when a fan is present. Signed-off-by: Ivor Wanders <ivor@iwanders.net> Link: #145 Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
jwrdegoede
pushed a commit
to jwrdegoede/linux-sunxi
that referenced
this pull request
Apr 1, 2024
Change naming from tmp to platform profile to clarify the module may interact with both the TMP and FAN subystems. Add functionality that switches the fan profile when the platform profile is changed when a fan is present. Signed-off-by: Ivor Wanders <ivor@iwanders.net> Link: linux-surface/kernel#145 Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> Link: https://lore.kernel.org/r/20240314223733.6236-2-ivor@iwanders.net Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #144 that adds support to switch the fan profile whenever the platform profile is switched.
Values recorded with IRPMon as sent to the FAN together with the numbers sent to the TMP module:
I've confirmed the changes in this PR using the following methodology;
echo balanced-performance > /sys/firmware/acpi/platform_profilefor normal)stress -c 12.stress -c 12after steady state has been reached, plus a bit (didn't time this). Mark time.This obtains us the following fan curves:
We clearly get 4 different fan max speeds, with performance as the highest level.