Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wake from suspend failing on alder/raptor lake #1120

Closed
GloriousEggroll opened this issue Apr 19, 2023 · 11 comments
Closed

Wake from suspend failing on alder/raptor lake #1120

GloriousEggroll opened this issue Apr 19, 2023 · 11 comments

Comments

@GloriousEggroll
Copy link

Wake from suspend failing on alder/raptor lake

  • Hardware model: Non-surface/NA
  • Kernel version:6.2.11
  • Distribution: Nobara

In Nobara's kernel we ship the linux-surface patches. It was found that one of the patches is causing alderlake/raptorlake desktops to not wake from suspend. We currently have two community members trying to figure out which patchset it is. Will provide more information once we know.

@ax0
Copy link

ax0 commented Apr 19, 2023

Just to add another data point: My Surface Pro 9 consistently fails to wake from suspend on kernel version 6.2.10 (running Arch Linux). I'm currently on 6.2.8 which only occasionally suffers from the same issue.

@StollD
Copy link
Member

StollD commented Apr 20, 2023

We do carry a fairly large patchset for alder lake devices: https://github.com/linux-surface/linux-surface/blob/master/patches/6.2/0015-intel-thread-director.patch

Have you already tried reverting that? This was added to improve battery life, so it is not surface-specific (Being honest, I actually think we shouldn't carry this, but on the other hand, it was reported that it doubles the battery life on these devices).

This is where it was suggested: #1084

@kostadinsh
Copy link

It was indeed the thread director patch. I have emailed Ricardo Neri (the creator of the patch) about the issue, and will update the issue here if/when he replies.

@qzed
Copy link
Member

qzed commented Apr 20, 2023

Thanks for testing! I'll remove the patchset from our sources for now.

@StollD
Copy link
Member

StollD commented Apr 20, 2023

Maybe we should split off these kinds of general-purpose patches in the future, so that you dont automatically get them when you pull in the surface patches. Like this one: https://github.com/linux-surface/linux-surface/blob/master/pkg/debian/kernel/0001-Revert-integrity-Only-use-machine-keyring-when-uefi_.patch

@qzed
Copy link
Member

qzed commented Apr 20, 2023

That's probably not a bad idea.

@pwilkutowski
Copy link

Guys one question

is this something that can also affect SP3 with Ubuntu and wayland / gnome?
IM fairly noobish to unix systems, and notices after relativity recent updated (some time back)

a very problematic wake from suspend when the system IS up but the display remains black

@qzed
Copy link
Member

qzed commented May 28, 2023

This should not affect the SP3. Also, the problematic patchset has been removed. So the SP3 issue should be separate.

@pwilkutowski
Copy link

pwilkutowski commented May 28, 2023 via email

@YosypC
Copy link

YosypC commented Jun 9, 2023

I also have this problem still on 6.3.6 SP8.

@qzed
Copy link
Member

qzed commented Jul 15, 2023

I'm closing this as this thread seems to go off-topic. The original issue was reported to be a problem with the Intel Thread Director patchset, which has been removed for a while now. If you still experience problems, please look for other issues that are a better fit it or open a new issue if you can't find an existing one.

@qzed qzed closed this as completed Jul 15, 2023
qzed added a commit that referenced this issue Jul 15, 2023
The CONFIG_IPC_CLASSES option has been introduced in a patchset adding
Intel Thread Director support. Unfortunately, this patchset had to be
removed due to complications (see issues #1084 and #1120), which was
done in commits b6c8d6a ("Update v6.2 patches") and a53f55d
("Update v6.1 patches"). Those commits accidentally left the now unused
CONFIG_IPC_CLASSES option in place, so remove it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants