feat: add ad_integration_preserve_authselect_profile #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: Add ad_integration_preserve_authselect_profile as a boolean parameter. Reason: Users need to be able to remove the `authselect` command from `sssd-enable-logins` to avoid overwriting previous PAM/nsswitch changes, until [RHEL-5101](https://issues.redhat.com/browse/RHEL-5101) is addressed. Result: Users can use the ad_integration role with PAM/nsswitch changes. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
|
[citest] |
|
Ack, LGTM. Could we ask the user who submitted the associated issue to test? |
justin-stephenson
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Add ad_integration_preserve_authselect_profile as a boolean
parameter.
Reason: Users need to be able to remove the
authselectcommand fromsssd-enable-loginsto avoid overwriting previous PAM/nsswitch changes,until RHEL-5101 is addressed.
Result: Users can use the ad_integration role with PAM/nsswitch changes.
Signed-off-by: Rich Megginson rmeggins@redhat.com