Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sets domain name lower case in realmd.conf section header #88

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

chuckmilam
Copy link
Contributor

@chuckmilam chuckmilam commented Mar 6, 2024

Enhancement: Set domain name lower case in realmd.conf section header

Reason: Realm specific sections should always contain the domain name in lower case as their section header.

…ader

Fixes linux-system-roles#87: Where realmd.conf expects the domain name in lower case as a section header.
…atch

Correctly sets lower case in realmd.conf.j2 section header
Copy link
Collaborator

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you for the fix.

@spetrosi
Copy link
Contributor

spetrosi commented Mar 7, 2024

[citest]

@spetrosi
Copy link
Contributor

spetrosi commented Mar 7, 2024

I updated PR summary. Posting the initial summary for history:

It appears the variable "ad_integration_computer_ou" does not do what I would expect it to do.

Per the README, it is:

"The distinguished name of an organizational unit to create the computer account."

As I painfully discovered over several days, setting this variable with an appropriate OU results in no change, and computers are joined to the domain in the default OU.

I looked through the code, and sure enough, "ad_integration_computer_ou" is only mentioned in the "realmd.conf.j2" file.

I've modified "tasks/main.yml" to correctly add the "--computer-ou" option to the "realm join" command, but before I jump through what appears to be pages of hoops setting up a Fedora VM and "tox-lsr" and whatnot, I figured I'd ask here to make sure I'm on the right track in believing the "ad_integration_computer_ou" variable should do more than just update a value in "sssd.conf."

@spetrosi spetrosi merged commit a4caa41 into linux-system-roles:main Mar 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants