Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Replace deprecated community.windows.win_domain_user and group modules #91

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

spetrosi
Copy link
Contributor

Enhancement: Replace deprecated community.windows.win_domain_user and group modules

Reason: community.windows.win_domain_group and community.windows.win_domain_user has been deprecated

Result: Tests use microsoft.ad.group and microsoft.ad.user instead

@spetrosi spetrosi requested a review from richm as a code owner March 25, 2024 15:33
@spetrosi
Copy link
Contributor Author

@jakub-vavra-cz PTAL

community.windows.win_domain_group has been deprecated.
community.windows.win_domain_user has been deprecated.

Use microsoft.ad.group instead and microsoft.ad.user instead.
@spetrosi spetrosi force-pushed the use-fresh-win-modules branch 2 times, most recently from 7effbe3 to 2685b87 Compare March 25, 2024 16:31
@spetrosi
Copy link
Contributor Author

[citest]

1 similar comment
@richm
Copy link
Contributor

richm commented Mar 25, 2024

[citest]

@richm
Copy link
Contributor

richm commented Mar 25, 2024

[citest failed]
looks like some sort of network flake

@richm
Copy link
Contributor

richm commented Mar 25, 2024

[citest bad]

@richm richm merged commit 2393930 into linux-system-roles:main Mar 25, 2024
25 checks passed
spetrosi added a commit to spetrosi/ad_integration that referenced this pull request Jun 24, 2024
linux-system-roles#91 replaced community.windows.win_domain_user with microsoft.ad.user
but new module has a different API.
spetrosi added a commit that referenced this pull request Jun 24, 2024
#91 replaced community.windows.win_domain_user with microsoft.ad.user
but new module has a different API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants