support collection-requirements.yml #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way for a role to automatically require collections for module/plugin dependencies. Use the non-standard file `meta/collection-requirements.yml` for this. Note that `meta/requirements.yml` is supposed to be a list of roles only, in the format described at https://docs.ansible.com/ansible/latest/galaxy/user_guide.html#installing-multiple-roles-from-multiple-files If we find a `meta/requirements.yml` file, and it is not in `list` format, assume it is an old one that has not yet been renamed to `meta/collection-requirements.yml`, use it, and warn the user.
|
This is related to linux-system-roles/tox-lsr#78 |
nhosoi
reviewed
May 5, 2022
| continue # legacy role format | ||
| if rqf == legacy_rqf: | ||
| logging.warning( | ||
| "The role %s is still using %s - please convert to %s instead", |
There was a problem hiding this comment.
I'm wondering to convert requirements.yml to collection-requirements.yml, are there anything else to do other than renaming the filename?
nhosoi
reviewed
May 5, 2022
| continue # legacy role format | ||
| if rqf == legacy_rqf: | ||
| logging.warning( | ||
| "The role %s is still using %s - please convert to %s instead", |
There was a problem hiding this comment.
I'm wondering to convert requirements.yml to collection-requirements.yml, are there anything else to do other than renaming the filename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way for a role to automatically require collections for
module/plugin dependencies. Use the non-standard file
meta/collection-requirements.ymlfor this. Note thatmeta/requirements.ymlis supposed to be a list of roles only, inthe format described at https://docs.ansible.com/ansible/latest/galaxy/user_guide.html#installing-multiple-roles-from-multiple-files
If we find a
meta/requirements.ymlfile, and it is not inlistformat, assume it is an old one that has not yet been renamed to
meta/collection-requirements.yml, use it, and warn the user.