ruamel now requires insertion of new key then deletion #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code would delete the old key using `pop` which would also retrieve the value of the old key, then insert the new key with the value at the old index. This causes ruamel 0.17.23 and later to crash with an "index out of range" error. Instead, retrieve the value, then insert the value with the new key at the old index, then finally delete the old key.
|
example of crash: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code would delete the old key using
popwhich would alsoretrieve the value of the old key, then insert the new key with the
value at the old index. This causes ruamel 0.17.23 and later to
crash with an "index out of range" error. Instead, retrieve the value,
then insert the value with the new key at the old index, then finally
delete the old key.