feat: Allow setting certificate and key files mode #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
add_fsattr_mode
branch
from
14b7a3b
to
bcd9e8a
Compare
|
[citest] |
|
I guess there already was a check for |
|
@rjeffman not sure what's going on - the tests expect that if mode is not present, the files will be created with |
|
@richm sorry, I've drowned in some other issues. I'll be looking at this issue this Friday (23/06). |
Allow setting of certificate and key files mode attribute through the use of the 'mode' parameter. The parameter follows Ansible's file mode rules, accepting either strings or integer values. Fixes linux-system-roles#133 Signed-off-by: Rafael Jeffman <rjeffman@redhat.com>
rjeffman
force-pushed
the
add_fsattr_mode
branch
from
bcd9e8a
to
aaa2393
Compare
|
[citest] |
|
@richm tests passed with the latest fix, can you review this PR? |
richm
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Allow seting of certificate and key files mode attribute through the use of the 'mode' parameter, when using the certmonger provider.
Reason: Previously, the certificate files generated by the certmonger provider used a default file mode that may not be suitable for some tools or for some more restricted environments.
Result: The file mode attribute can now be set using the same roles as Ansible's file mode parameter, accepting either a string or an integer.
Issue Tracker Tickets (Jira or BZ if any): https://bugzilla.redhat.com/show_bug.cgi?id=2180902