Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix python unit test - copy pytest config to tests/unit #218

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

richm
Copy link
Collaborator

@richm richm commented Feb 2, 2024

This is fixed by tox-lsr 3.2.2 - all actions that use tox-lsr are updated to
3.2.2, not just the python unit tests, even though the fix is only related to
pytest. All roles are updated to use tox-lsr 3.2.2 for the sake of consistency
even if not affected by the pytest issue.

Something changed recently in the way github actions provisions systems which
means some of the directories are not readable by the python unit test actions.
In addition, the python unit tests were causing a lot of unnecessary directory
traversal doing collection/discovery of unit test files, because of using
pytest -c /path/to/tox-lsr/pytest.ini Unfortunately, with pytest, the
directory of the config file is the root directory for the tests and tests
discovery, and there is no way around this.

Therefore, the only solution is to copy the tox-lsr pytest.ini to the
tests/unit directory, which makes that the test root directory.

See also linux-system-roles/tox-lsr#160

Signed-off-by: Rich Megginson rmeggins@redhat.com

This is fixed by tox-lsr 3.2.2 - all actions that use tox-lsr are updated to
3.2.2, not just the python unit tests, even though the fix is only related to
pytest.  All roles are updated to use tox-lsr 3.2.2 for the sake of consistency
even if not affected by the pytest issue.

Something changed recently in the way github actions provisions systems which
means some of the directories are not readable by the python unit test actions.
In addition, the python unit tests were causing a lot of unnecessary directory
traversal doing collection/discovery of unit test files, because of using
`pytest -c /path/to/tox-lsr/pytest.ini` Unfortunately, with `pytest`, the
directory of the config file is the root directory for the tests and tests
discovery, and there is no way around this.

Therefore, the only solution is to copy the tox-lsr `pytest.ini` to the
`tests/unit` directory, which makes that the test root directory.

See also linux-system-roles/tox-lsr#160

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from rjeffman as a code owner February 2, 2024 16:48
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68e1843) 32.95% compared to head (95cead6) 32.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files           3        3           
  Lines         613      613           
  Branches      128      128           
=======================================
  Hits          202      202           
  Misses        411      411           
Flag Coverage Δ
sanity 32.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm richm merged commit 31e76be into main Feb 2, 2024
18 checks passed
@richm richm deleted the tox-lsr-3.2.2 branch February 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant