Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add supported_ansible_also to .ansible-lint #226

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

richm
Copy link
Collaborator

@richm richm commented Jun 5, 2024

This fixes the breakage of ansible-test.

We want to advertise support for ansible 2.14 since some of
our collections will be supported for a long time on this
version. The latest version of ansible-lint requires 2.15
in meta/runtime.yml, but it also adds support for a way to
tell ansible-lint other versions which are acceptable, using
the new supported_ansible_also configuration option
in .ansible-lint

With this fix, we can support both the latest version of
ansible-test and ansible-lint.

See linux-system-roles/auto-maintenance#341
for more information.

Signed-off-by: Rich Megginson rmeggins@redhat.com

This fixes the breakage of ansible-test.

We want to advertise support for ansible 2.14 since some of
our collections will be supported for a long time on this
version.  The latest version of ansible-lint requires 2.15
in meta/runtime.yml, but it also adds support for a way to
tell ansible-lint other versions which are acceptable, using
the new `supported_ansible_also` configuration option
in .ansible-lint

With this fix, we can support both the latest version of
ansible-test and ansible-lint.

See linux-system-roles/auto-maintenance#341
for more information.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.95%. Comparing base (ac27251) to head (8241902).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files           3        3           
  Lines         613      613           
  Branches      128      128           
=======================================
  Hits          202      202           
  Misses        411      411           
Flag Coverage Δ
sanity 32.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm richm merged commit 477ced6 into main Jun 5, 2024
18 checks passed
@richm richm deleted the supported_ansible_also branch June 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant