Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel_report module #58

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

mprovenc
Copy link

New kernel_report module to pull settings from an existing template machine and apply them to a number of target machines. This also required adding "device-specific" support to the existing kernel_settings system role so that, similar to tuneD, it allows for changing kernel settings that are associated with particular devices.

A few notes about the PR and outstanding items that will need to be reviewed before merging:

  • unit testing for the kernel_report module is somewhat complete and probably sufficient for now, though there could probably be more/better coverage added
  • The README file needs to be updated to reflect the new formatting for some of the kernel_settings options. This format is best documented in defaults/main.yml, though the README should probably include it since this was significant formatting change
  • I did not check other ansible tests to make sure that the kernel_settings role still works in all these scenarios (the CI should catch some of those issues, though it should probably be looked over before merging since this PR brings some playbook formatting changes)
  • There are a list of sysctl fields from Joe Mario that can be added to the list kernel_report module and tested (I will link a corresponding issue to this PR)

Basic functionality of kernel settings report module
Move everything to python functionality instead of using shell scripts,
change the format of the output to be more consistent with
kernel_settings role input, filter out some known unstable values
Also convert unstable settings list to regex for more flexibility
Simple two host test to apply kernel settings output from kernel_report
module to another machine
Assumes that two images will be specified as TEST_SUBJECTS: One CentOS
image and one Fedora image
Taken from the tuned documentation and existing profiles, support added
for more parameters which the kernel_settings role should allow users to
change
Update apply_kernel_report_settings test
Add special logic so that if one of these values is read in as '0', the
kernel_report plugin will ignore it and only populate one of the
bytes/ratio fields
Tested with two Fedora machines sharing an identical release
@richm
Copy link
Contributor

richm commented May 1, 2021

[citest commit:ed44dbad1e58faef5a4ca4a2db2e6cdcd0691dfe]

@jharuda
Copy link

jharuda commented May 3, 2021

[citest pending]

1 similar comment
@richm
Copy link
Contributor

richm commented May 4, 2021

[citest pending]

@richm
Copy link
Contributor

richm commented May 4, 2021

[citest bad]

@richm
Copy link
Contributor

richm commented May 4, 2021

[citest pending]

3 similar comments
@richm
Copy link
Contributor

richm commented Oct 11, 2021

[citest pending]

@richm
Copy link
Contributor

richm commented Oct 11, 2021

[citest pending]

@richm
Copy link
Contributor

richm commented Oct 20, 2021

[citest pending]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants