Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make role work with ansible-core-2.11 ansible-lint and ansible-test #65

Merged
merged 1 commit into from Oct 7, 2021
Merged

make role work with ansible-core-2.11 ansible-lint and ansible-test #65

merged 1 commit into from Oct 7, 2021

Conversation

richm
Copy link
Contributor

@richm richm commented Oct 7, 2021

No description provided.

spetrosi
spetrosi reviewed Oct 7, 2021
View reviewed changes
tox.ini Outdated

[qemu_common]
setenv =
LSR_QEMU_INVENTORY = /home/rmeggins/standard-test-roles/inventory/standard-inventory-qcow2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richm will it take the inventory script from your home dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richm will it take the inventory script from your home dir?

good catch - I removed tox.ini from the PR

spetrosi
spetrosi approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@spetrosi spetrosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richm richm merged commit eb5fd62 into linux-system-roles:master Oct 7, 2021
@richm richm deleted the ansible-lint-test-2.11 branch October 7, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetrosi spetrosi spetrosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richm @spetrosi