Allowing the case, tls is false and key/certs vars are configured. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
reviewed
Aug 23, 2021
| - myprivkey: "{{ __test_key_target }}" | ||
| register: __result | ||
| changed_when: false | ||
| failed_when: __result.rc != 1 |
There was a problem hiding this comment.
do you use this __result anywhere else? If not, then the default failed condition here is if the grep in the command returns non-zero, so I think you can get rid of the register and the failed_when here.
richm
reviewed
Aug 24, 2021
tests/tests_files_elasticsearch.yml
Outdated
| - "{{ __test_cert_target }}" | ||
| - "{{ __test_key_target }}" | ||
|
|
||
| - name: Check key/certs in {{ __test_outputfiles_conf }} |
There was a problem hiding this comment.
Should this be "Check key/certs not in {{ __test_outputfiles_conf }}" ?
- The case used to fail in the checking task with emitting an error. The error is transformed to a warning. - For the test case, TEST CASE 2 in tests_files_elasticsearch.yml is added. In addition, some minor bugs in tests_files_elasticsearch.yml are fixed. ref: bz1994580
|
Thank you, @richm. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is transformed to a warning.
is added.
In addition, some minor bugs in tests_files_elasticsearch.yml are
fixed.
ref: bz1994580