New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ansible-core 2.11 #253
Conversation
.ansible-lint
Outdated
@@ -1,3 +1,3 @@ | |||
--- | |||
skip_list: | |||
- '303' # systemctl used in place of systemd module | |||
- role-name # role name does not match pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to have both of these - so that ansible 2.9 ansible-lint will pass as well as ansible-lint 2.11
a2c575c
to
130691a
Compare
@nhosoi note that the tox CI here is still using ansible-lint 2.9, which requires the numeric identifiers in the .ansible-lint like We still have to support both ansible-lint 2.9 and ansible-lint 2.11 for some time. |
Sorry, I did not know the string identifiers are not available for 2.9... I'm going to replace them with the numerical ones. (there is one issue which may not work well... but it's not in logging, but in vpn. so, i'm switching to the pr.) |
Updated .ansible-lint to skip a role name warning in the meta file. Added "name" to debug tasks to satisfy ansible-lint.
130691a
to
b2eabe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you, @richm. Merging. |
Updated .ansible-lint to skip a role name warning in the meta file.
Added "name" to debug tasks to satisfy ansible-lint.