Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ansible-core 2.11 #253

Merged
merged 1 commit into from Oct 7, 2021

Conversation

nhosoi
Copy link
Contributor

@nhosoi nhosoi commented Oct 7, 2021

Updated .ansible-lint to skip a role name warning in the meta file.

Added "name" to debug tasks to satisfy ansible-lint.

.ansible-lint Outdated
@@ -1,3 +1,3 @@
---
skip_list:
- '303' # systemctl used in place of systemd module
- role-name # role name does not match pattern
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to have both of these - so that ansible 2.9 ansible-lint will pass as well as ansible-lint 2.11

@richm
Copy link
Collaborator

richm commented Oct 7, 2021

@nhosoi note that the tox CI here is still using ansible-lint 2.9, which requires the numeric identifiers in the .ansible-lint like '303', not the string identifiers like role-name, which are used by ansible-lint 2.11. In my testing, ansible-lint 2.9 will ignore the string identifiers, and ansible-lint 2.11 will ignore the numeric identifiers, so you can use both in .ansible-lint.

We still have to support both ansible-lint 2.9 and ansible-lint 2.11 for some time.

@nhosoi
Copy link
Contributor Author

nhosoi commented Oct 7, 2021

@nhosoi note that the tox CI here is still using ansible-lint 2.9, which requires the numeric identifiers in the .ansible-lint like '303', not the string identifiers like role-name, which are used by ansible-lint 2.11. In my testing, ansible-lint 2.9 will ignore the string identifiers, and ansible-lint 2.11 will ignore the numeric identifiers, so you can use both in .ansible-lint.

We still have to support both ansible-lint 2.9 and ansible-lint 2.11 for some time.

Sorry, I did not know the string identifiers are not available for 2.9... I'm going to replace them with the numerical ones. (there is one issue which may not work well... but it's not in logging, but in vpn. so, i'm switching to the pr.)

Updated .ansible-lint to skip a role name warning in the meta file.

Added "name" to debug tasks to satisfy ansible-lint.
Copy link
Collaborator

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nhosoi
Copy link
Contributor Author

nhosoi commented Oct 7, 2021

Thank you, @richm. Merging.

@nhosoi nhosoi merged commit 7186802 into linux-system-roles:master Oct 7, 2021
@nhosoi nhosoi deleted the ansible-core-2.11 branch June 30, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants