Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for general queue and general action parameters #364

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

MrZmurf
Copy link
Contributor

@MrZmurf MrZmurf commented Nov 1, 2023

Enhancement: Add support for general queue and general action parameters in output modules

Reason: The role is missing the ability to configure general queue parameters and general action parameters

Result: This PR implements a way to add general queue and general action parameters to output modules

Issue Tracker Tickets (Jira or BZ if any):

@richm richm changed the title Add support for general queue and general action parameters feat: Add support for general queue and general action parameters Nov 1, 2023
@richm
Copy link
Collaborator

richm commented Nov 1, 2023

[citest]

@richm
Copy link
Collaborator

richm commented Nov 1, 2023

@MrZmurf This is a really cool patch - thanks! I would really like to have some sort of test for this - do you see any of the tests in the tests directory that we could add some queue or action parameters to?

@MrZmurf
Copy link
Contributor Author

MrZmurf commented Nov 1, 2023

@MrZmurf This is a really cool patch - thanks! I would really like to have some sort of test for this - do you see any of the tests in the tests directory that we could add some queue or action parameters to?

tests_basics_forwards.yml could probably test both queue and action parameters like queue.spooldirectory="/var/spool/rsyslog", queue.filename="forwards", queue.saveonshutdown="on" and action.resumeretrycount=50 and action.resumeInterval=300 or something like that

@MrZmurf
Copy link
Contributor Author

MrZmurf commented Nov 1, 2023

In tests_remote.yml the action.reportsuspension could be set to "on" and action.reportsuspensioncontinuation to "off" just to test the other way the template is used when it writes all options on the same line

@richm
Copy link
Collaborator

richm commented Nov 1, 2023

@MrZmurf MrZmurf#1

tests for action and queue parameters
MrZmurf and others added 2 commits November 2, 2023 15:29
Co-authored-by: Richard Megginson <richm@stanfordalumni.org>
Co-authored-by: Richard Megginson <richm@stanfordalumni.org>
@richm
Copy link
Collaborator

richm commented Nov 2, 2023

[citest]

@richm richm merged commit dc1fa59 into linux-system-roles:main Nov 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants