fix: avoid conf of RatelimitBurst when RatelimitInterval is zero #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
changed the title
|
[citest] |
richm
reviewed
Dec 7, 2023
richm
reviewed
Dec 7, 2023
richm
reviewed
Dec 7, 2023
|
[citest] |
|
ok - I fixed the test failures with #374 |
@brakkio86 please rebase your patch on top of the latest |
Co-authored-by: Richard Megginson <richm@stanfordalumni.org>
Co-authored-by: Richard Megginson <richm@stanfordalumni.org>
Co-authored-by: Richard Megginson <richm@stanfordalumni.org>
richm
force-pushed
the
journal_rate_limit
branch
from
68047fc
to
1b1db99
Compare
never mind - turns out I can do and did that |
|
[citest] |
richm
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: As documented in main rsyslog documentation,
ratelimit.bursthave some sense only whenratelimit.intervalis configured and different from zero.Reason: Improve
ratelimit.burstconfiguration whenratelimit.intervalis disable (equal to zero)Result:
ratelimit.burstis not present whenratelimit.intervalis disable (equal to zero)Issue Tracker Tickets (Jira or BZ if any):