Skip to content

Commit

Permalink
Reorder tasks such that Redis started before PCP services
Browse files Browse the repository at this point in the history
Current versions of the pmproxy daemon in PCP attempt to
connect to Redis immediately on startup and disable some
functionality if that fails.

This should be fixed in PCP in due course but there's no
harm in starting Redis service first in the metrics role
(if metric_query is requested) to avoid the problem.
  • Loading branch information
natoscott committed Jul 7, 2021
1 parent 0673d84 commit 06f9aa5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions tasks/main.yml
Expand Up @@ -53,6 +53,13 @@
name: "{{ role_path }}/roles/bpftrace"
when: metrics_from_bpftrace|d(false)|bool

- name: Setup metric querying service.
vars:
redis_metrics_provider: "{{ metrics_provider }}"
include_role:
name: "{{ role_path }}/roles/redis"
when: metrics_query_service|d(false)|bool

- name: Setup metric collection service.
vars:
pcp_pmlogger_discard: "{{ metrics_retention_days }}"
Expand All @@ -65,13 +72,6 @@
name: "{{ role_path }}/roles/pcp"
when: metrics_provider == 'pcp'

- name: Setup metric querying service.
vars:
redis_metrics_provider: "{{ metrics_provider }}"
include_role:
name: "{{ role_path }}/roles/redis"
when: metrics_query_service|d(false)|bool

- name: Setup metric graphing service.
vars:
grafana_metrics_provider: "{{ metrics_provider }}"
Expand Down

0 comments on commit 06f9aa5

Please sign in to comment.